Resolve environment variables case-insensitively on Windows #9438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IKEDA Yasuyuki <[email protected]>
|
Looks conflicted with #9499 |
…itiveEnv # Conflicts: # pkg/compose/run.go Signed-off-by: IKEDA Yasuyuki <[email protected]>
milas
approved these changes
Jul 29, 2022
|
Oops, conflicted again (with #9636). |
…itiveEnv # Conflicts: # pkg/compose/run.go Signed-off-by: IKEDA Yasuyuki <[email protected]>
laurentsimon
pushed a commit
to laurentsimon/compose
that referenced
this pull request
Aug 10, 2022
Signed-off-by: IKEDA Yasuyuki <[email protected]>
|
Fixed in v2.10.0: https://github.com/docker/compose/releases/tag/v2.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This change resolves following environment variables case-insensitively on Windows:
services.SERVICE.build.args[].--argoptions inbuildsub command.-eoptions inrunsub command.This doesn't fix followings. It will be fixed with compose-spec/compose-go#257 (and updating references in go.mod/go.sum)
services.SERVICE.environment[].Related issue
(not mandatory) A picture of a cute animal, if possible in relation with what you did